[asterisk-dev] [Code Review] [18801] - features reload does not clear old configuration and always include 700 on parkedcalls : patch

jrose reviewboard at asterisk.org
Wed Apr 6 15:06:00 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1161/
-----------------------------------------------------------

(Updated 2011-04-06 15:06:00.414928)


Review request for Asterisk Developers, David Vossel and rbyrant.


Changes
-------

Changes made based on the suggestions of David Vossel


Summary
-------

This fix follows a completely different approach from the other one, so I created a new review request.
This fix involves wiping all the parking lots in the parkinglots ao2_container while purging their extensions so that they have to be rebuilt when features reload is performed.

I have a bit more confidence in this one.  It's much more additive and much less destructive than the last one.


This addresses bug 18801.
    https://issues.asterisk.org/view.php?id=18801


Diffs (updated)
-----

  /trunk/main/features.c 312991 

Diff: https://reviewboard.asterisk.org/r/1161/diff


Testing
-------

Tested with multiple parking lots, changing multiple parking lots, with and without [general], with general and then without general and then with general again (which showed a need for an additional change), and mixes of all the above.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110406/0fc03460/attachment.htm>


More information about the asterisk-dev mailing list