[asterisk-dev] [Code Review] CEL cel_odbc backend fails to insert eventtype into integer or other numeric column

kkm reviewboard at asterisk.org
Mon Apr 4 13:13:25 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1160/
-----------------------------------------------------------

(Updated 2011-04-04 13:13:25.723835)


Review request for Asterisk Developers and Tilghman Lesher.


Changes
-------

Per Tilgman's review:
LENGTHEN_BUF2 argument adjusted x2;
usegmtime used when getting date time x3.

Thank you for looking at it!


Summary
-------

If eventtype is numeric in the database, it gets set to NULL, not to one of the numeric values as documented in cel_odbc.conf.sample.


This addresses bug 18964.
    https://issues.asterisk.org/view.php?id=18964


Diffs (updated)
-----

  /trunk/cel/cel_odbc.c 312554 

Diff: https://reviewboard.asterisk.org/r/1160/diff


Testing
-------

After preproduction testing, the change deployed to large scale production since March, 21.


Thanks,

kkm

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110404/c0b412ac/attachment.htm>


More information about the asterisk-dev mailing list