[asterisk-dev] [Code Review] CEL cel_odbc backend fails to insert eventtype into integer or other numeric column

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1160/#review3274
-----------------------------------------------------------



/trunk/cel/cel_odbc.c
<https://reviewboard.asterisk.org/r/1160/#comment6776>

    usegmtime?



/trunk/cel/cel_odbc.c
<https://reviewboard.asterisk.org/r/1160/#comment6777>

    This value should not have decremented to 15, as the format string still has a maximum result length of 17.



/trunk/cel/cel_odbc.c
<https://reviewboard.asterisk.org/r/1160/#comment6778>

    usegmtime?



/trunk/cel/cel_odbc.c
<https://reviewboard.asterisk.org/r/1160/#comment6779>

    Why is this necessary?



/trunk/cel/cel_odbc.c
<https://reviewboard.asterisk.org/r/1160/#comment6780>

    Why is this changing from 15 to 16?  Maximum length of the format string is still 15.


- Tilghman


On 2011-04-03 22:16:18, kkm wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1160/
> -----------------------------------------------------------
> 
> (Updated 2011-04-03 22:16:18)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> If eventtype is numeric in the database, it gets set to NULL, not to one of the numeric values as documented in cel_odbc.conf.sample.
> 
> 
> This addresses bug 18964.
>     https://issues.asterisk.org/view.php?id=18964
> 
> 
> Diffs
> -----
> 
>   /trunk/cel/cel_odbc.c 312554 
> 
> Diff: https://reviewboard.asterisk.org/r/1160/diff
> 
> 
> Testing
> -------
> 
> After preproduction testing, the change deployed to large scale production since March, 21.
> 
> 
> Thanks,
> 
> kkm
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110404/d60ce555/attachment.htm>