[asterisk-dev] [Code Review] Add CLI-command "cdr pgsql status" based on "cdr mysql status"

[Russell Bryant]

> On 2010-09-30 12:01:21, Russell Bryant wrote:
> > /trunk/cdr/cdr_pgsql.c, lines 143-152
> > <https://reviewboard.asterisk.org/r/923/diff/1/?file=12549#file12549line143>
> >
> >     There's got to be a way to convert seconds to a friendly time string without open coding it like this.  Perhaps strftime()?
> 
> Tilghman Lesher wrote:
>     There really isn't, although strftime would be a creative way to make it work.  However, it is unlikely to work for years; only up to days.  (Use tm_yday, tm_hour, tm_min, and tm_sec, and make sure you use the "UTC" timezone).

Thanks for the feedback, Tilghman.  If you're fine with how it is, then I'm fine with it.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/923/#review2790
-----------------------------------------------------------


On 2010-09-17 06:25:54, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/923/
> -----------------------------------------------------------
> 
> (Updated 2010-09-17 06:25:54)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Adds a CLI command to check the status of the cdr_pgsql.so driver
> 
> 
> This addresses bug 18009.
>     https://issues.asterisk.org/view.php?id=18009
> 
> 
> Diffs
> -----
> 
>   /trunk/cdr/cdr_pgsql.c 287085 
> 
> Diff: https://reviewboard.asterisk.org/r/923/diff
> 
> 
> Testing
> -------
> 
> The 1.4 version has been in production for more than a month.
> 
> 
> Thanks,
> 
> Olle E
> 
>