[asterisk-dev] [Code Review] Add CLI-command "cdr pgsql status" based on "cdr mysql status"

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/923/#review2790
-----------------------------------------------------------



/trunk/cdr/cdr_pgsql.c
<https://reviewboard.asterisk.org/r/923/#comment5986>

    Initialization to 0 is unnecessary, and it's recommended that you leave it off.



/trunk/cdr/cdr_pgsql.c
<https://reviewboard.asterisk.org/r/923/#comment5987>

    There's got to be a way to convert seconds to a friendly time string without open coding it like this.  Perhaps strftime()?



/trunk/cdr/cdr_pgsql.c
<https://reviewboard.asterisk.org/r/923/#comment5988>

    You can use ARRAY_LEN(cdr_pgsql_status_cli) instead of the division you have here.


- Russell


On 2010-09-17 06:25:54, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/923/
> -----------------------------------------------------------
> 
> (Updated 2010-09-17 06:25:54)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Adds a CLI command to check the status of the cdr_pgsql.so driver
> 
> 
> This addresses bug 18009.
>     https://issues.asterisk.org/view.php?id=18009
> 
> 
> Diffs
> -----
> 
>   /trunk/cdr/cdr_pgsql.c 287085 
> 
> Diff: https://reviewboard.asterisk.org/r/923/diff
> 
> 
> Testing
> -------
> 
> The 1.4 version has been in production for more than a month.
> 
> 
> Thanks,
> 
> Olle E
> 
>