[asterisk-dev] [Code Review] Newchannel AMI event is missing during masquerading process.

[Russell Bryant]

> On 2010-09-24 09:34:50, David Vossel wrote:
> > If slashes are allowed in the name, then doesn't this only help if one extra slash is present? What if there are a whole bunch of them?  Is there anyway this can be written to work in all circumstances?  or maybe it already is and I'm missing something.

We just need to know if the channel name is for a valid channel type and not something like "Dummy/" which is used in places where we create fake channels for convenience purposes.  The channel tech is almost always before the first slash, but there are some cases, "AsyncGoto/tech/args" at least, but I think there maybe others, where it's second.  I don't think we need to handle anything beyond the 2nd field.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/937/#review2783
-----------------------------------------------------------


On 2010-09-23 15:46:23, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/937/
> -----------------------------------------------------------
> 
> (Updated 2010-09-23 15:46:23)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Newchannel AMI event is missing during masquerading process.
> 
> 
> This addresses bug 17987.
>     https://issues.asterisk.org/view.php?id=17987
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/main/channel.c 288493 
>   /branches/1.6.2/main/channel.c 288498 
>   /branches/1.8/main/channel.c 288499 
> 
> Diff: https://reviewboard.asterisk.org/r/937/diff
> 
> 
> Testing
> -------
> 
> Tested submitters patch, but noticed possible errors with Local calling extensions that have a slash or an agent with a slash in his name.
> 
> Wrote patch submitted here, and tested before and after the patch in 1.4, 1.6.2, 1.8, and trunk branches.
> 
> 
> Thanks,
> 
> Brett
> 
>