[asterisk-dev] [Code Review] Manager listens even when not enabled.

Russell Bryant russell at digium.com
Thu Sep 23 13:03:52 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/938/#review2778
-----------------------------------------------------------

Ship it!


- Russell


On 2010-09-23 13:02:05, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/938/
> -----------------------------------------------------------
> 
> (Updated 2010-09-23 13:02:05)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Manager listens even when not enabled. This patch sets the default ami/amis_desc to all 0 and only copies correct values if manager is enabled. When ast_tcptls_server_start is called, it now behaves properly.
> 
> 
> This addresses bug 18040.
>     https://issues.asterisk.org/view.php?id=18040
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/manager.c 287936 
> 
> Diff: https://reviewboard.asterisk.org/r/938/diff
> 
> 
> Testing
> -------
> 
> starting up with disabled, reload with enabled, then reload with disabled.
> 
> 
> Thanks,
> 
> Terry
> 
>




More information about the asterisk-dev mailing list