[asterisk-dev] [Code Review] Newchannel AMI event is missing during masquerading process.

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/937/#review2776
-----------------------------------------------------------



/branches/1.4/main/channel.c
<https://reviewboard.asterisk.org/r/937/#comment5982>

    Perhaps we could make this a bit more "future proof" so that the fix isn't specific to the "AsyncGoto" prefix.  How about checking for the case where there are two instances of '/' in the channel name, and if so, checking the first two fields (split on '/') for a valid technology type.


- Russell


On 2010-09-22 19:54:12, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/937/
> -----------------------------------------------------------
> 
> (Updated 2010-09-22 19:54:12)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Newchannel AMI event is missing during masquerading process.
> 
> 
> This addresses bug 17987.
>     https://issues.asterisk.org/view.php?id=17987
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/main/channel.c 288493 
> 
> Diff: https://reviewboard.asterisk.org/r/937/diff
> 
> 
> Testing
> -------
> 
> Tested submitters patch, but noticed possible errors with Local calling extensions that have a slash or an agent with a slash in his name.
> 
> Wrote patch submitted here, and tested before and after the patch in 1.4, 1.6.2, 1.8, and trunk branches.
> 
> 
> Thanks,
> 
> Brett
> 
>