[asterisk-dev] [Code Review] Don't let a Local channel get bridged to itself

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/934/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Through craziness, it is currently possible to get a Local channel bridged to itself.

[default]
exten => _XXXX,n,Dial(SIP/${EXTEN})
exten => _7XXXX,1,Dial(Local/${EXTEN:1}/nm)

Dialing 76002 from a SIP phone and sending a REFER replacing the original call results in the two SIP channels going away, but leaving an orphaned Local channel with the ,1 side bridged to the ,2 side. The only way to hang up the call then is through the CLI, AMI, etc.

This patch catches the attempt to bridge a local channel to its other side in the fixup() callback, and denies it.


Diffs
-----

  /branches/1.4/channels/chan_local.c 288419 

Diff: https://reviewboard.asterisk.org/r/934/diff


Testing
-------

Tested before and after on 1.4 and trunk. After the patch, the call is hung up if someone tries something so silly.


Thanks,

Terry