[asterisk-dev] [Code Review] New Manager Action: MeetmeListRooms

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/874/#review2766
-----------------------------------------------------------



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/874/#comment5960>

    This should be 'total++'.



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/874/#comment5961>

    If cnf->markedusers is not 0 this sprintf will cause a crash.  Use either a fixed size buffer here or an ast_str string.


- Matthew


On 2010-09-07 03:06:09, rcasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/874/
> -----------------------------------------------------------
> 
> (Updated 2010-09-07 03:06:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I've added a new manager action to list only the active conferences on an
> Asterisk system. It shows the same data displayed when you run a 'meetme
> list' on the Asterisk CLI
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 283270 
> 
> Diff: https://reviewboard.asterisk.org/r/874/diff
> 
> 
> Testing
> -------
> 
> Tested with static, dynamic and realtime conferences.
> 
> 
> Thanks,
> 
> rcasas
> 
>