[asterisk-dev] [Code Review] awesome review

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/925/
-----------------------------------------------------------

(Updated 2010-09-20 10:51:00.391822)


Review request for Asterisk Developers and Russell Bryant.


Changes
-------

This update changes the name from AwesomeHooks to FrameHooks.  The AWESOME_TRACE() dialplan function is not FRAME_TRACE().  I have addressed most of russell's comments here.  I'm still not sure if I will do anything about his comment pertaining to the id field of the framehook.  I also did not address his tweak concerning the FRAME_TRACE frame array structure.


Summary
-------

I wrote a new API called AwesomeHook.  It allows for ast_frames to be intercepted, viewed, and modified while being read and written to a channel.  Detailed documentation pertaining to this API can be found in awesomehook.h.  I have also included a new dialplan function called AWESOME_TRACE() which exercises the AwesomeHook API.  Documentation and use of this function can be found in func_awesome_trace.c.


Diffs (updated)
-----

  /branches/1.8/funcs/func_frame_trace.c PRE-CREATION 
  /branches/1.8/include/asterisk/channel.h 287554 
  /branches/1.8/include/asterisk/framehook.h PRE-CREATION 
  /branches/1.8/main/channel.c 287554 
  /branches/1.8/main/framehook.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/925/diff


Testing
-------


Thanks,

David