[asterisk-dev] [Code Review] awesome review

[David Vossel]

----- Original Message -----
> From: "Kevin P. Fleming" <kpfleming at digium.com>
> To: asterisk-dev at lists.digium.com
> Sent: Monday, September 20, 2010 7:29:47 AM
> Subject: Re: [asterisk-dev] [Code Review] awesome review
> On 09/20/2010 07:06 AM, Vadim Lebedev wrote:
> > On 09/20/2010 11:03 AM, Klaus Darilion wrote:
> >>
> >> Am 17.09.2010 21:05, schrieb David Vossel:
> >>
> >>> ----- Original Message -----
> >>>
> >>>> From: "Mark Murawski"<markm at intellasoft.net>
> >>>> To: asterisk-dev at lists.digium.com
> >>>> Sent: Friday, September 17, 2010 1:12:03 PM
> >>>> Subject: Re: [asterisk-dev] [Code Review] awesome review
> >>>> I would suggest a different name. What about AudioFrameHook ?
> >>>>
> >>> This hook is not specific to only audio frames. Plus that name is
> >>> not very awesome.
> >>>
> >> I would also suggest a more meaningful name - even if it is
> >> awesome.
> >> Although I do not know what it exactly does, what about:
> >>
> >> GenericMediaHook?
> >> GenericFrameHook?
> >> FrameHook
> >> AstFrameHook
> >> MediaHook?
> >> AwesomeFrameHook?
> >> AwesomeAstFrameHook?
> >>
> >
> > Klaus,
> >
> > You forgot the obvious:
> > MediaFrameHook
> 
> No, the whole point of this is API is that it is *not* restricted to
> media frames. I've already suggested 'ChannelShim' to David, which I
> think is the best way to describe what this API does.
> 


I'm changing the name to FrameHook as I believe that best describes the API's usage.  Thanks for letting me try to get away with calling it awesomehooks though :p

~David