[asterisk-dev] [Code Review] awesome review

[Mark Murawski]

On 09/17/2010 12:37 PM, David Vossel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/925/
> -----------------------------------------------------------
>
> Review request for Asterisk Developers and Russell Bryant.
>
>
> Summary
> -------
>
> I wrote a new API called AwesomeHook.  It allows for ast_frames to be intercepted, viewed, and modified while being read and written to a channel.  Detailed documentation pertaining to this API can be found in awesomehook.h.  I have also included a new dialplan function called AWESOME_TRACE() which exercises the AwesomeHook API.  Documentation and use of this function can be found in func_awesome_trace.c.
>
>
> Diffs
> -----
>
>    /branches/1.8/funcs/func_awesome_trace.c PRE-CREATION
>    /branches/1.8/include/asterisk/awesomehook.h PRE-CREATION
>    /branches/1.8/include/asterisk/channel.h 287384
>    /branches/1.8/main/awesomehook.c PRE-CREATION
>    /branches/1.8/main/channel.c 287384
>
> Diff: https://reviewboard.asterisk.org/r/925/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> David
>
>

I would suggest a different name.  What about AudioFrameHook ?