[asterisk-dev] [Code Review] VERBOSE message shows up on console when 'debug' enabled in logger.conf

Russell Bryant russell at digium.com
Fri Sep 17 09:55:57 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/915/#review2739
-----------------------------------------------------------



/branches/1.8/main/logger.c
<https://reviewboard.asterisk.org/r/915/#comment5918>

    I slightly misspoke before.  It's the verbosers that *do* need the first byte.  The messages sent to the log files are the ones that should not have the byte.
    
    Also, please fill in the "testing done" section of the review request.


- Russell


On 2010-09-14 18:12:29, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/915/
> -----------------------------------------------------------
> 
> (Updated 2010-09-14 18:12:29)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch fixes an issue where calling ast_verbose would place formatted verbose messages to the console when it wasn't supposed to.
> 
> 
> This addresses bug 17974.
>     https://issues.asterisk.org/view.php?id=17974
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/logger.c 286375 
> 
> Diff: https://reviewboard.asterisk.org/r/915/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brett
> 
>




More information about the asterisk-dev mailing list