[asterisk-dev] [Code Review] Add parking extension for non-default parking lots

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/884/#review2730
-----------------------------------------------------------

Ship it!


Other than one minor issue that needs to be fixed in a module that probably isn't being built on your box, this looks good to go.

Nice work, Jeff!


/trunk/channels/chan_mgcp.c
<https://reviewboard.asterisk.org/r/884/#comment5906>

    I bet this doesn't compile.  :-)


- Russell


On 2010-09-15 12:27:09, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/884/
> -----------------------------------------------------------
> 
> (Updated 2010-09-15 12:27:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I think the summary says all here, this was just something that wasn't implemented when multiparking was added.
> 
> 
> This addresses bug 14882.
>     https://issues.asterisk.org/view.php?id=14882
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 286903 
>   /trunk/channels/chan_dahdi.c 286903 
>   /trunk/channels/chan_iax2.c 286903 
>   /trunk/channels/chan_mgcp.c 286903 
>   /trunk/channels/chan_sip.c 286903 
>   /trunk/channels/sig_analog.c 286903 
>   /trunk/channels/sip/include/sip.h 286903 
>   /trunk/configs/features.conf.sample 286903 
>   /trunk/include/asterisk/features.h 286903 
>   /trunk/main/features.c 286903 
> 
> Diff: https://reviewboard.asterisk.org/r/884/diff
> 
> 
> Testing
> -------
> 
> I tested as I went and ran all of our parking tests.
> 
> 
> Thanks,
> 
> Jeff
> 
>