[asterisk-dev] [Code Review] chan_iax2: load config before registering any functions

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/914/#review2710
-----------------------------------------------------------

Ship it!



branches/1.4/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/914/#comment5862>

    Technically, if the modules is going to DECLINE, it should be cleaning up all resources that it has allocated/initialized before returning.  However, that problem already existed before your patch.  Your patch makes the situation better, but there is more that could be done.  This is a good step, though.


- Russell


On 2010-09-10 14:25:36, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/914/
> -----------------------------------------------------------
> 
> (Updated 2010-09-10 14:25:36)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Check for iax.conf first, before registering any functions, applications or actions.  Otherwise, if you 'module load chan_iax2.so' without iax.conf, some functions, applications and actions will be registered however the module will fail to load.  Allowing you to run 'module load chan_iax2.so' again, causing asterisk to spike to 99% CPU.
> 
> Plus some additional formating.
> 
> 
> Diffs
> -----
> 
>   branches/1.4/channels/chan_iax2.c 281181 
> 
> Diff: https://reviewboard.asterisk.org/r/914/diff
> 
> 
> Testing
> -------
> 
> compile, install, module load / unload chan_iax2.so
> 
> 
> Thanks,
> 
> pabelanger
> 
>