[asterisk-dev] [Code Review] chan_iax2: load config before registering any functions

[paul.belanger at polybeacon.com]

> On 2010-09-10 14:10:36, Russell Bryant wrote:
> > branches/1.4/channels/chan_iax2.c, lines 12766-12775
> > <https://reviewboard.asterisk.org/r/914/diff/2/?file=12479#file12479line12766>
> >
> >     I would move all of this before set_config()

Will do.  For my own learning, its safe to call ast_mutex_init(&waresl.lock) more then once before destroying it?  Same question for AST_LIST_HEAD_INIT(&iaxq.queue).


- pabelanger


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/914/#review2706
-----------------------------------------------------------


On 2010-09-10 13:25:45, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/914/
> -----------------------------------------------------------
> 
> (Updated 2010-09-10 13:25:45)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Check for iax.conf first, before registering any functions, applications or actions.  Otherwise, if you 'module load chan_iax2.so' without iax.conf, some functions, applications and actions will be registered however the module will fail to load.  Allowing you to run 'module load chan_iax2.so' again, causing asterisk to spike to 99% CPU.
> 
> Plus some additional formating.
> 
> 
> Diffs
> -----
> 
>   branches/1.4/channels/chan_iax2.c 281181 
> 
> Diff: https://reviewboard.asterisk.org/r/914/diff
> 
> 
> Testing
> -------
> 
> compile, install, module load / unload chan_iax2.so
> 
> 
> Thanks,
> 
> pabelanger
> 
>