[asterisk-dev] [Code Review] VERBOSE message shows up on console when 'debug' enabled in logger.conf

Russell Bryant russell at digium.com
Fri Sep 10 13:50:31 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/915/#review2705
-----------------------------------------------------------



/tags/1.8.0-beta5/main/logger.c
<https://reviewboard.asterisk.org/r/915/#comment5858>

    I think this will have an unintended side effect.  We still want verbose in log files, just not the console.  For example, if I do:
    
    verbose => verbose
    
    in logger.conf, this patch will make it so that file will now be empty.


- Russell


On 2010-09-10 13:44:33, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/915/
> -----------------------------------------------------------
> 
> (Updated 2010-09-10 13:44:33)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch fixes an issue where calling ast_verbose would place formatted verbose messages to the console when it wasn't supposed to.
> 
> 
> This addresses bug 17974.
>     https://issues.asterisk.org/view.php?id=17974
> 
> 
> Diffs
> -----
> 
>   /tags/1.8.0-beta5/main/logger.c 285737 
> 
> Diff: https://reviewboard.asterisk.org/r/915/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brett
> 
>




More information about the asterisk-dev mailing list