[asterisk-dev] [Code Review] New testsuite test for call files and pbx_spool

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/906/#review2690
-----------------------------------------------------------

Ship it!


My comments now are just formatting


/asterisk/trunk/tests/pbx/call-files/run-test
<https://reviewboard.asterisk.org/r/906/#comment5843>

    you can remove this import now



/asterisk/trunk/tests/pbx/call-files/run-test
<https://reviewboard.asterisk.org/r/906/#comment5844>

    add spaces around '='



/asterisk/trunk/tests/pbx/call-files/run-test
<https://reviewboard.asterisk.org/r/906/#comment5845>

    the indentation of the 2nd line by only 1 space seems odd to me.  Check PEP8 to see what it has to say on this matter and follow its recommendation.


- Russell


On 2010-09-07 14:20:37, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/906/
> -----------------------------------------------------------
> 
> (Updated 2010-09-07 14:20:37)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This test runs two call files through asterisk to ensure that both call files connecting extensions, and call files connecting applications both work properly.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/pbx/call-files/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/pbx/call-files/run-test PRE-CREATION 
>   /asterisk/trunk/tests/pbx/call-files/sample.call PRE-CREATION 
>   /asterisk/trunk/tests/pbx/call-files/sample2.call PRE-CREATION 
>   /asterisk/trunk/tests/pbx/call-files/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 785 
> 
> Diff: https://reviewboard.asterisk.org/r/906/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brett
> 
>