[asterisk-dev] [Code Review] handle_request_subscribe is too slow cause of iterating through all sip dialogs

sst at sil.at sst at sil.at
Fri Sep 3 18:18:27 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/901/
-----------------------------------------------------------

(Updated 2010-09-03 18:18:27.843180)


Review request for Asterisk Developers.


Changes
-------

red dot removed and added check for p->subscribed so it couldnt be a notify not being in a subscribe dialog.


Summary
-------

in chan_sip.c the handle_request_subscribe function is very slow cause of iterating through all sip dialogs on every subscribe, to find old subscribes from this peer to exten at context. This patch will disable this iteration cause its not necessary.


Diffs (updated)
-----

  branches/1.6.2/channels/chan_sip.c 284848 

Diff: https://reviewboard.asterisk.org/r/901/diff


Testing
-------


Thanks,

schmidts




More information about the asterisk-dev mailing list