[asterisk-dev] [Code Review] Fix how mutexes are created/destroyed on platforms which need constructors

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/894/#review2661
-----------------------------------------------------------


This looks pretty good, although I'm a bit confused how this could be helping on a platform that has gcc 4.2 if the constructor priority attribute is only supported on gcc 4.3 and later.


/branches/1.4/autoconf/ast_gcc_attribute.m4
<https://reviewboard.asterisk.org/r/894/#comment5824>

    Please call the second parameter "attribute_label" or something, since it's not an argument to the attribute.



/branches/1.4/include/asterisk/linkedlists.h
<https://reviewboard.asterisk.org/r/894/#comment5825>

    These macros should be undefined before leaving the HAVE_ATTRIBUTE_constructor_with_priority block.



/branches/1.4/include/asterisk/lock.h
<https://reviewboard.asterisk.org/r/894/#comment5826>

    Please use syntax consistent with what is already in the file... in this case, we have "#if defined(...)" followed by "#ifdef".


- Kevin


On 2010-09-02 23:42:31, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/894/
> -----------------------------------------------------------
> 
> (Updated 2010-09-02 23:42:31)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Checks for a new constructor argument, as of gcc 4.3, which allows priorities to be assigned to each constructor, thus indicating a construction order (ascending) and destructor order (descending).  Also removes the destructor for files in main, when priorities aren't available.
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/autoconf/ast_gcc_attribute.m4 284776 
>   /branches/1.4/configure UNKNOWN 
>   /branches/1.4/configure.ac 284776 
>   /branches/1.4/include/asterisk/autoconfig.h.in 284776 
>   /branches/1.4/include/asterisk/linkedlists.h 284776 
>   /branches/1.4/include/asterisk/lock.h 284776 
>   /branches/1.4/main/Makefile 284776 
> 
> Diff: https://reviewboard.asterisk.org/r/894/diff
> 
> 
> Testing
> -------
> 
> Eliminates some of the warnings on OS X 10.6 (gcc 4.2) upon quit, as mutexes don't get destroyed too early.
> 
> 
> Thanks,
> 
> Tilghman
> 
>