[asterisk-dev] [Code Review] Updates to parking

[Mitch Sharp]

> On 2010-10-07 15:37:48, Terry Wilson wrote:
> >

I agree with setting them to unsigned int, but shouldn't we leave the < 1 check in to keep them from setting the time to 0 (zero)?  A zero time would also ring for a very, very long time.  :-)

All the other changes have been made.  Will update a new diff once I get a little more feedback.

Thanks Terry!


- Mitch


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/963/#review2813
-----------------------------------------------------------


On 2010-10-01 02:05:57, Mitch Sharp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/963/
> -----------------------------------------------------------
> 
> (Updated 2010-10-01 02:05:57)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I posted a patch to issues a few weeks ago that duplicated some existing features.  (https://issues.asterisk.org/view.php?id=17947)
> 
> I have reworked it to extend the existing parking behavior.
> 
> This patch does the following:
> - Make comebacktoorigin a per-parkinglot option.
> - Make parkedmusicclass a per-parkinglot option, and make sure parkinglot->parking_con_dial gets set to "park-dial" for additional parking lots instead of being left NULL (already have a patch in issues for this for as a fix for 1.8.0-beta4, https://issues.asterisk.org/view.php?id=17946)
> - Adds a per-parkinglot option comebackcontext, which defaults to the usual 'parkedcallstimeout' context.  Allows the user to handle timed out calls for different parking lots in different contexts.
> - Adds a per-parkinglot option comebackdialtime, which allows user to override the dial time specified in automatically created extensions when comebacktoorigin=yes.
> - Adds channel variable PARKER to timed out calls, so user can easily dial the original device that parked the call if comebacktoorigin=no.
> - Update CLI command 'features show' to include the comebacktoorigin, comebackcontext and comebackdialtime values.
> - Updated /configs/features.conf.sample
> 
> This patch doesn't change any default behavior.
> 
> Looking forward to some feedback.
> 
> 
> This addresses bugs 0017946 and 0017947.
>     https://issues.asterisk.org/view.php?id=0017946
>     https://issues.asterisk.org/view.php?id=0017947
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/features.conf.sample 289621 
>   /trunk/main/features.c 289621 
> 
> Diff: https://reviewboard.asterisk.org/r/963/diff
> 
> 
> Testing
> -------
> 
> I have been running this code in a 1.6.2.4 server and a 1.6.2.13 server for a week now.  There are a total of ~130 SIP registrations and 14 parking lots between the two servers.
> 
> I ported it to 1.8.0-rc2 and trunk and compiled successfully.  This diff is specifically against trunk.
> 
> 
> Thanks,
> 
> Mitch
> 
>