[asterisk-dev] [Code Review] Don't crash on a bogus Set()

Terry Wilson twilson at digium.com
Wed Oct 6 18:48:20 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/949/#review2810
-----------------------------------------------------------

Ship it!


Looks sane to me.

- Terry


On 2010-09-29 16:36:55, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/949/
> -----------------------------------------------------------
> 
> (Updated 2010-09-29 16:36:55)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A crash was reported internally that occurs on an invalid usage of Set().  This patch resolves it.
> 
> 
> Diffs
> -----
> 
>   /branches/1.6.2/main/pbx.c 289337 
> 
> Diff: https://reviewboard.asterisk.org/r/949/diff
> 
> 
> Testing
> -------
> 
> exten => 7001,1,Set(DB(family/key))
> 
> crashed before the patch, emits a warning after the patch
> 
> 
> Thanks,
> 
> Russell
> 
>




More information about the asterisk-dev mailing list