[asterisk-dev] [Code Review] Updates to parking

[Mitch Sharp]

I submitted this to the review board and added asterisk-dev to Groups,
but it never showed up here.  It's my first time submitting to the
review board so I'm learning.

-----------------------------------------------------------
This is a manually generated e-mail of something
that should have happened automatically.  :-)
To reply, visit:
https://reviewboard.asterisk.org/r/963/
-----------------------------------------------------------

Review request for Asterisk Developers.

Description
-----------
I posted a patch to issues a few weeks ago that duplicated some existing
features.  (https://issues.asterisk.org/view.php?id=17947)

I have reworked it to extend the existing parking behavior.

This patch does the following:
- Make comebacktoorigin a per-parkinglot option.
- Make parkedmusicclass a per-parkinglot option, and make sure
parkinglot->parking_con_dial gets set to "park-dial" for additional
parking lots instead of being left NULL (already have a patch in issues
for this for as a fix for 1.8.0-beta4,
https://issues.asterisk.org/view.php?id=17946)
- Adds a per-parkinglot option comebackcontext, which defaults to the
usual 'parkedcallstimeout' context.  Allows the user to handle timed out
calls for different parking lots in different contexts.
- Adds a per-parkinglot option comebackdialtime, which allows user to
override the dial time specified in automatically created extensions
when comebacktoorigin=yes.
- Adds channel variable PARKER to timed out calls, so user can easily
dial the original device that parked the call if comebacktoorigin=no.
- Update CLI command 'features show' to include the comebacktoorigin,
comebackcontext and comebackdialtime values.
- Updated /configs/features.conf.sample

This patch doesn't change any default behavior.

Looking forward to some feedback.


Diffs
-----
https://reviewboard.asterisk.org/r/963/diff


Testing
-------
I have been running this code in a 1.6.2.4 server and a 1.6.2.13 server
for a week now.  There are a total of ~130 SIP registrations and 14
parking lots between the two servers.

I ported it to 1.8.0-rc2 and trunk and compiled successfully.  This diff
is specifically against trunk.


Thanks,

Mitch Sharp
BIG Networks
5647 Galeria Drive, Suite D
Baton Rouge, LA 70816
tel: 225.214.1444 x101
fax: 225.214.1443
email: msharp at bignetworks.com
web: www.bignetworks.com