[asterisk-dev] [Code Review] ConfBridge User Announce Feature Set

Andrew Parisio reviewboard at asterisk.org
Mon Nov 29 12:55:38 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1011/
-----------------------------------------------------------

(Updated 2010-11-29 12:55:37.904426)


Review request for Asterisk Developers.


Changes
-------

Changes made, including changing the h option to v like we did for app_meetme @ leif's suggestions.  I couldn't find the spacing issues so I completely re-tabbed them from scratch just to make sure I got it right.


Summary
-------

I copied the i and I features from meetme, as well as the same h functionality I posted in reviewboard 1009.  

I noticed I could cause a segfault if I called in from extension 1, then called in from extensions 2 and 3 at the exact same time but they had to be almost identically timed.  This didn't seem to happen in the trunk version so I think it's part of this patch.  I'm not sure if it's related to one of the locks on the bridge but I'm hoping somebody that is more knowledgeable about ConfBridge may be able to help there.


Diffs (updated)
-----

  /trunk/apps/app_confbridge.c 294568 

Diff: https://reviewboard.asterisk.org/r/1011/diff


Testing
-------

ConfBridge(1,i)
ConfBridge(1,I)
ConfBridge(1,h(1593 at default))


Thanks,

Andrew

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101129/bb76bf68/attachment.htm 


More information about the asterisk-dev mailing list