[asterisk-dev] [Code Review] saynumber(1, n) doesn't work with language = SE

Russell Bryant reviewboard at asterisk.org
Mon Nov 22 13:59:42 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1031/#review2964
-----------------------------------------------------------

Ship it!


- Russell


On 2010-11-22 13:57:21, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1031/
> -----------------------------------------------------------
> 
> (Updated 2010-11-22 13:57:21)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> saynumber(1,n) doesn't work since the check for gender for number one is AFTER the check for number below 20. Fixed with this patch. 
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/main/say.c 295784 
> 
> Diff: https://reviewboard.asterisk.org/r/1031/diff
> 
> 
> Testing
> -------
> 
> Tested on local system. Works properly.
> 
> Sidenote: We should document the language-specific prompts outside of the source code.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101122/015c1ff7/attachment.htm 


More information about the asterisk-dev mailing list