[asterisk-dev] [Code Review] app_queue: Log failed attempts to call members

haakon reviewboard at asterisk.org
Sun Nov 21 17:17:58 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1028/
-----------------------------------------------------------

Review request for Asterisk Developers and Paul Belanger.


Summary
-------

Add information about the reason a call was not answered by the queue-member.
In queue_log a RINGNOANSWER is generated, with no information about the reason.

This patch gives information about the hangup reason of call-attempts to queue members.
This way you can check which calls that was having technical dificulties, and which was just ignored by the member.

The patch changes the behaviour of queue log by adding HANGUPCAUSE as the last parameter to queue_log "RINGNOANSWER", and adding "Reason:" parameter to AMI-event AgentRingNoAnswer..

Both additions give you a textual representation of the hangup-cause.
(had to add cause2shortstr() in channel.c for this)


This addresses bug 16925.
    https://issues.asterisk.org/view.php?id=16925


Diffs
-----

  trunk/UPGRADE.txt 295785 
  trunk/apps/app_queue.c 295785 
  trunk/include/asterisk/channel.h 295785 
  trunk/main/channel.c 295785 

Diff: https://reviewboard.asterisk.org/r/1028/diff


Testing
-------

Called into queues with several valid and invalid memebers and checked queue_log and AMI for correct hangupcauses.

queue_log example output:
1290380780|1290378912.0|queuetest|DAHDI/g0/12345678|RINGNOANSWER|0|NORMAL_CIRCUIT_CONGESTION


Thanks,

haakon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101121/866ab76d/attachment.htm 


More information about the asterisk-dev mailing list