[asterisk-dev] [Code Review] SayUnixTime always tryes to reach the extension as digit pressed.

[reviewboard at asterisk.org]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/956/#review2931
-----------------------------------------------------------

Ship it!


Beyond the style comments below, this looks fine.


trunk/apps/app_sayunixtime.c
<https://reviewboard.asterisk.org/r/956/#comment6167>

    Put spaces between '/*' and '*/' and the comments.



trunk/apps/app_sayunixtime.c
<https://reviewboard.asterisk.org/r/956/#comment6168>

    Same here.


- Matthew


On 2010-11-17 06:01:08, jlpedrosa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/956/
> -----------------------------------------------------------
> 
> (Updated 2010-11-17 06:01:08)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> If SayUnixTime is running on a channel, if that peer sends DMTF tones, always tryes to reach the extension as digit pressed.
> 
> Here's the patch made against the trunk, but the files are identical in 1.6 branch from svn so patch can be aplied without warings on both branchs.
> 
> Changes made:
> 1) Now by default SayUnixTime does not jump to extension when digits pressed.
> 2) New paramater 'options' added as last argument. It's an option list (AST_APP_OPTIONS) whith only one option:
>      'j' for jumping to extension pressed.
> 
> 
> This addresses bug https://issues.asterisk.org/view.php?id=17989#c127536.
>     https://issues.asterisk.org/view.php?id=https://issues.asterisk.org/view.php?id=17989#c127536
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_sayunixtime.c 286867 
>   trunk/include/asterisk/file.h 286867 
> 
> Diff: https://reviewboard.asterisk.org/r/956/diff
> 
> 
> Testing
> -------
> 
> Compiled and tested whith both new values.
> 
> 
> Thanks,
> 
> jlpedrosa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101118/e4259da8/attachment.htm