[asterisk-dev] [Code Review] Fix how mutexes are created/destroyed on platforms which need constructors

Tilghman Lesher tlesher at digium.com
Mon Nov 8 16:10:52 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/894/
-----------------------------------------------------------

(Updated 2010-11-08 16:10:52.031849)


Review request for Asterisk Developers.


Changes
-------

Force module constructors to be at priority 5000.


Summary
-------

Checks for a new constructor argument, as of gcc 4.3, which allows priorities to be assigned to each constructor, thus indicating a construction order (ascending) and destructor order (descending).  Also removes the destructor for files in main, when priorities aren't available.


Diffs (updated)
-----

  /branches/1.4/autoconf/ast_gcc_attribute.m4 294276 
  /branches/1.4/configure UNKNOWN 
  /branches/1.4/configure.ac 294276 
  /branches/1.4/include/asterisk/autoconfig.h.in 294276 
  /branches/1.4/include/asterisk/linkedlists.h 294276 
  /branches/1.4/include/asterisk/lock.h 294276 
  /branches/1.4/include/asterisk/module.h 294276 
  /branches/1.4/main/Makefile 294276 

Diff: https://reviewboard.asterisk.org/r/894/diff


Testing
-------

Eliminates some of the warnings on OS X 10.6 (gcc 4.2) upon quit, as mutexes don't get destroyed too early.


Thanks,

Tilghman




More information about the asterisk-dev mailing list