[asterisk-dev] [Code Review] [17949] Error that mutex 'dialog' has been free'd more than it's been locked in add_header_max_forwards

[Brett Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/997/
-----------------------------------------------------------

(Updated 2010-11-05 16:34:29.840409)


Review request for Asterisk Developers.


Summary
-------

Some functions passing the sip_pvt structure dialog to add_header_max_forwards were not following proper locking order, and this patch is intended to fix that.


This addresses bug 17949.
    https://issues.asterisk.org/view.php?id=17949


Diffs (updated)
-----

  /branches/1.8/channels/chan_sip.c 283596 

Diff: https://reviewboard.asterisk.org/r/997/diff


Testing
-------

SIP tests from testsuite succeed in both the original 1.8 branch, and a copy of the 1.8 branch containing this patch.


Thanks,

Brett