[asterisk-dev] [Code Review] [17949] Error that mutex 'dialog' has been free'd more than it's been locked in add_header_max_forwards

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/997/#review2890
-----------------------------------------------------------


Other than the suggestion to remove this lock, I think this is good to go.  I'm glad we came to a much cleaner approach!


/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/997/#comment6112>

    Based on most of the code that leads up to this, I think we should just retain the original assumption that the sip_pvt is locked before calling this function.  I know it may not be true in a couple of cases, but I think it should be.  I'd rather assume that than introduce recursive lock usage if we can get away with it.


- Russell


On 2010-11-05 14:35:49, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/997/
> -----------------------------------------------------------
> 
> (Updated 2010-11-05 14:35:49)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Some functions passing the sip_pvt structure dialog to add_header_max_forwards were not following proper locking order, and this patch is intended to fix that.
> 
> 
> This addresses bug 17949.
>     https://issues.asterisk.org/view.php?id=17949
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 283596 
> 
> Diff: https://reviewboard.asterisk.org/r/997/diff
> 
> 
> Testing
> -------
> 
> SIP tests from testsuite succeed in both the original 1.8 branch, and a copy of the 1.8 branch containing this patch.
> 
> 
> Thanks,
> 
> Brett
> 
>