[asterisk-dev] [Code Review] [17949] Error that mutex 'dialog' has been free'd more than it's been locked in add_header_max_forwards

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/997/#review2887
-----------------------------------------------------------



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/997/#comment6095>

    transferer should already be locked here coming into local_attended_transfer.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/997/#comment6096>

    Same thing here.  I believe transferer is already locked.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/997/#comment6097>

    should already be locked.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/997/#comment6098>

    p should already be locked here.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/997/#comment6099>

    p should be locked here



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/997/#comment6100>

    p should be locked already



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/997/#comment6101>

    already locked.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/997/#comment6102>

    p should already be locked



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/997/#comment6103>

    p should already be locked in this function since it is called in handle_response_invite.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/997/#comment6104>

    p is already locked in this function



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/997/#comment6106>

    p is already locked in this function


- David


On 2010-11-04 14:34:19, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/997/
> -----------------------------------------------------------
> 
> (Updated 2010-11-04 14:34:19)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Some functions passing the sip_pvt structure dialog to add_header_max_forwards were not following proper locking order, and this patch is intended to fix that.
> 
> 
> This addresses bug 17949.
>     https://issues.asterisk.org/view.php?id=17949
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 283596 
> 
> Diff: https://reviewboard.asterisk.org/r/997/diff
> 
> 
> Testing
> -------
> 
> SIP tests from testsuite succeed in both the original 1.8 branch, and a copy of the 1.8 branch containing this patch.
> 
> 
> Thanks,
> 
> Brett
> 
>