[asterisk-dev] Help needed for main/pbx.c

Stefan Schmidt sst at sil.at
Wed Nov 3 14:02:24 CDT 2010


Am 03.11.2010 17:47, schrieb Jeff Peeler:
> A 1.4 based branch is located here:
> 
> https://origsvn.digium.com/svn/asterisk/team/jpeeler/issue18165
> 
> I was never able to reproduce the issue, so any testing is appreciated.
> 
> Jeff Peeler
> Digium, Inc. | Software Developer
> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
> Check us out at www.digium.com & www.asterisk.org
> 
thanks jeff to commit this patch,

only one thing i have noticed by looking over the code is that you use
the container only as a link list with one bucket. i may be wrong but
isnt an extension unique in every context?
wouldnt it be better to use the hint->exten value for hash cmp cause you
use several times ao2_find with an extension but only have one single
ao2_callback to get hints by callback id.

its just a question if there is a reason i have not seen ;)

thx

best regards

stefan





More information about the asterisk-dev mailing list