[asterisk-dev] [Code Review] Add Path header support to chan_sip

Klaus Darilion klaus.mailinglists at pernau.at
Tue Nov 2 16:08:43 CDT 2010


-----------------------------------------------------------
This is a manually generated e-mail (as reviewboard didn't worked). To 
reply, visit:
https://reviewboard.asterisk.org/r/991/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This patch adds support for the Parse header (RFC 3327). This allows to 
record the Path (route) of incoming REGISTER requests and then reuse the 
learned path on outgoing out-of-dialog requests as a pre-loaded route set.

I tried to reuse as much of existing code as possible. There are several 
parts where I am not sure if it is implemented nice and follow chan_sip 
design rules (are there any?) I will post my questions as a review to 
myself. Thus, it would be nice if someone can answer my questions.


Testing
-------

Basic testing done (with nat=yes|no, with and without outboundproxy set 
for a peer, with and without Parse header, single Parse header and two 
Parse headers, restarting Asterisk)


Thanks,
Klaus




More information about the asterisk-dev mailing list