[asterisk-dev] [Code Review] Set threshold for silence detection defaults 256
paul.belanger at polybeacon.com
paul.belanger at polybeacon.com
Mon May 31 12:20:52 CDT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/670/
-----------------------------------------------------------
(Updated 2010-05-31 12:20:52.279702)
Review request for Asterisk Developers.
Changes
-------
v4:
Updates for Russell's comments.
Summary
-------
Repost of a tracker issue for dsp.c. Created a default setting for 265, not 0.
---
dant's comments:
* Defines a default silence threshold constant set to the current default of 256
* If the config file is not present, issues a warning saying that it will use the default silence threshold and applies the default silence threshold
* Where the variable was set to a static value, i.e. in the event that the config existed but didn't define the variable or if it was set to an invalid value, it now uses the constant to apply the default value.
This addresses bug 15685.
https://issues.asterisk.org/view.php?id=15685
Diffs
-----
/trunk/main/dsp.c 266284
Diff: https://reviewboard.asterisk.org/r/670/diff
Testing
-------
compile testing
Thanks,
pabelanger
More information about the asterisk-dev
mailing list