[asterisk-dev] [Code Review] Initial set of Queue tests

David Vossel dvossel at digium.com
Fri May 28 10:18:47 CDT 2010 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/638/#review2107
-----------------------------------------------------------


I have one comment that kind of falls over all of these tests.  What happens when Asterisk crashes or deadlocks?  Are we guaranteed that the tests will timeout at some point and return?  Since I am not very familiar with the lua framework being used, it is hard for me to know for sure what will happen.  In the python tests we have written there has always been some sort of failsafe timeout used to guarantee the test would exit if something went wrong.


/asterisk/trunk/tests/queues/queue_baseline/test.lua
<https://reviewboard.asterisk.org/r/638/#comment4468>

    I noticed in your previous test that the sleep was only 1. Here it is 2.  By chance did you have it set to 1 here and find that the test did not pass consistently?  If so I don't think it would hurt to raise this in the other places as well... It would be nice if this could just be done another way rather than waiting and hoping the messages arrive in time, but I understand this limitation given the tool set.



/asterisk/trunk/tests/queues/queue_baseline/test.lua
<https://reviewboard.asterisk.org/r/638/#comment4469>

    I noticed you logoff the manager here before terminating the asterisk instance.  In the other tests you did not do this.  It shouldn't matter, just thought I'd point it out since it was an inconsistency.



/asterisk/trunk/tests/queues/ringinuse_and_pause/test.lua
<https://reviewboard.asterisk.org/r/638/#comment4471>

    Do you need a sleep here before pump_messages like in the other tests?



/asterisk/trunk/tests/queues/ringinuse_and_pause/test.lua
<https://reviewboard.asterisk.org/r/638/#comment4470>

    I don't see where Asterisk is terminated for this test.



/asterisk/trunk/tests/queues/wrapup_time/test.lua
<https://reviewboard.asterisk.org/r/638/#comment4474>

    Again, why is this 3.  If this was just experimentation on your box and 3 appeared to work best, that might be kind of aggressive for slower machines.



/asterisk/trunk/tests/queues/wrapup_time/test.lua
<https://reviewboard.asterisk.org/r/638/#comment4473>

    Is sleep because it is taking longer than expected for the two asterisk instances to start? You did not do this in the other tests.  If it because of this you may want to make this one longer that 1 second since on slower machines it might take quite a bit longer.  We need a better way of knowing when asterisk is fully loaded.



/asterisk/trunk/tests/queues/wrapup_time/test.lua
<https://reviewboard.asterisk.org/r/638/#comment4472>

    Do we need to close the asterisk instances here?


- David


On 2010-04-30 16:46:45, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/638/
> -----------------------------------------------------------
> 
> (Updated 2010-04-30 16:46:45)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A set of five queue tests.
> 
> 1. Queue Baseline: Places a call to a queue and ensures that the call goes through as expected by watching for manager events
> 2. Wrapup Time: Places calls to queue members and then ensures that the member cannot be reached during wrapuptime. Tests both regular queues and sharedlastcall instances.
> 3. Gosub/macro: Tests that macros and gosubs are executed as expected when a member answers. Tests both static configuration and overriding with parameters to the Queue application.
> 4. Ringinuse and Pause: Tests that members are not called if ringinuse=no. Ensures that autopause only takes effect if the member is attempted to be called. Ensures that paused members do not get called.
> 5. Position, Priority, and maxlen: Adds a bunch of callers to a queue and ensures that they enter at the position we expect them to.
> 
> I have ideas for about 15 more tests, but those will have to come later.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/queues/macro_gosub_test/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/macro_gosub_test/configs/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/macro_gosub_test/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/macro_gosub_test/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/macro_gosub_test/test.lua PRE-CREATION 
>   /asterisk/trunk/tests/queues/position_priority_maxlen/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/position_priority_maxlen/configs/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/position_priority_maxlen/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/position_priority_maxlen/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/position_priority_maxlen/test.lua PRE-CREATION 
>   /asterisk/trunk/tests/queues/queue_baseline/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/queue_baseline/configs/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/queue_baseline/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/queue_baseline/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/queue_baseline/test.lua PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/configs/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/configs/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/sipp/uas.xml PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/test.lua PRE-CREATION 
>   /asterisk/trunk/tests/queues/wrapup_time/configs/ast1/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/wrapup_time/configs/ast2/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/wrapup_time/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/wrapup_time/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/wrapup_time/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/wrapup_time/test.lua PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 275 
> 
> Diff: https://reviewboard.asterisk.org/r/638/diff
> 
> 
> Testing
> -------
> 
> Ran the tests. They pass.
> 
> 
> Thanks,
> 
> Mark
> 
>

More information about the asterisk-dev mailing list