[asterisk-dev] [Code Review] Add regular expression blacklist filtering for manager events

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/673/#review2104
-----------------------------------------------------------



/trunk/CHANGES
<https://reviewboard.asterisk.org/r/673/#comment4461>

    I think there is still a use case for the blacklist, even though the whitelist is more common.  What do you think about making the whitelist functionality an addition instead of a replacement?



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/673/#comment4462>

    If you're going to go the route of using astobj2, you might as well go all the way an use an astobj2 container instead of a linked list.  I don't think there is a need for having them ordered.


- Russell


On 2010-05-27 15:33:08, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/673/
> -----------------------------------------------------------
> 
> (Updated 2010-05-27 15:33:08)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> From the submitter:
> to allow better filtering of ami-events than configuring categories, I created an option "eventfilter" for manager-users. Events to be sent are matched against regexes specified in these options and are discarded if the regex matches (blacklisting).
> 
> 
> This addresses bug 14861.
>     https://issues.asterisk.org/view.php?id=14861
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 266240 
>   /trunk/configs/manager.conf.sample 266240 
>   /trunk/main/manager.c 266240 
> 
> Diff: https://reviewboard.asterisk.org/r/673/diff
> 
> 
> Testing
> -------
> 
> I ensured manager events are reported the same without filtering and works as expected with.
> 
> 
> Thanks,
> 
> Jeff
> 
>