[asterisk-dev] [Code Review] Add regular expression blacklist filtering for manager events

Jeff Peeler jpeeler at digium.com
Wed May 26 15:21:36 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/673/
-----------------------------------------------------------

(Updated 2010-05-26 15:21:36.411827)


Review request for Asterisk Developers.


Changes
-------

Address memory management concerns. Should be race condition free with the users list lock.


Summary
-------

>From the submitter:
to allow better filtering of ami-events than configuring categories, I created an option "eventfilter" for manager-users. Events to be sent are matched against regexes specified in these options and are discarded if the regex matches (blacklisting).


This addresses bug 14861.
    https://issues.asterisk.org/view.php?id=14861


Diffs (updated)
-----

  /trunk/CHANGES 266103 
  /trunk/configs/manager.conf.sample 266103 
  /trunk/main/manager.c 266103 

Diff: https://reviewboard.asterisk.org/r/673/diff


Testing
-------

I ensured manager events are reported the same without filtering and works as expected with.


Thanks,

Jeff




More information about the asterisk-dev mailing list