[asterisk-dev] [Code Review] SIP peers & IAX2 users/peers AstData providers and unit testing.

[paul.belanger at polybeacon.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/642/#review2092
-----------------------------------------------------------


Plan to give this ago next week, 1 question and comment.


/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/642/#comment4442>

    No even sure it is worth the work, but 
    
    .path = "/asterisk/channels/... 
    
    So it follows the source directory structure?



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/642/#comment4443>

    Red blob.


- pabelanger


On 2010-05-03 13:47:50, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/642/
> -----------------------------------------------------------
> 
> (Updated 2010-05-03 13:47:50)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> - AstData Search engine modified to simplify each data provider.
> - SIP peers/users data provider + unit testing.
> - IAX2 peers/users data provider + unit testing.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_queue.c 260752 
>   /trunk/apps/app_voicemail.c 260752 
>   /trunk/channels/chan_iax2.c 260752 
>   /trunk/channels/chan_sip.c 260752 
>   /trunk/include/asterisk/data.h 260752 
>   /trunk/main/channel.c 260752 
>   /trunk/main/data.c 260752 
> 
> Diff: https://reviewboard.asterisk.org/r/642/diff
> 
> 
> Testing
> -------
> 
> Developer testing.
> 
> 
> Thanks,
> 
> Eliel
> 
>