[asterisk-dev] [Code Review] Extract sig_ss7 out of chan_dahdi.

[paul.belanger at polybeacon.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/661/#review2088
-----------------------------------------------------------


Another set of eyes for formatting.  95% of comments are about missing braces. ;)

Good work.


/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/661/#comment4401>

    Spacing after comma's



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/661/#comment4402>

    bracers for if statements.



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/661/#comment4403>

    More braces.



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4404>

    To be removed?



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4405>

    braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4406>

    ditto



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4407>

    more braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4408>

    same as above.



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4409>

    more braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4410>

    ditto



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4411>

    braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4412>

    braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4413>

    braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4414>

    braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4415>

    more braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4416>

    spacing between +



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4417>

    braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4418>

    ditto



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4419>

    Is this considered a mid-block variables?



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4420>

    more braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4421>

    more braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4422>

    trivial, space before comment



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4423>

    more braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4424>

    ditto



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4425>

    more braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4426>

    braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4427>

    same as above



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4428>

    same as above



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4429>

    same as above



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4430>

    same as above



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4431>

    same as above



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4432>

    same as above



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4433>

    more braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4435>

    ditto



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4436>

    braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4437>

    braces



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/661/#comment4438>

    braces


- pabelanger


On 2010-05-14 17:31:07, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/661/
> -----------------------------------------------------------
> 
> (Updated 2010-05-14 17:31:07)
> 
> 
> Review request for Asterisk Developers and mattf.
> 
> 
> Summary
> -------
> 
> Extract the SS7 specific code out of chan_dahdi like what was done to ISDN/PRI and analog signaling.  The new SS7 structures were modeled on sig_pri.
> 
> The changes to sig_pri are an enhancement and a bug fix made possible because SS7 was extracted.
> 1) The sig_pri TRANSFERCAPABILITY channel variable should have been set unconditionally in sig_pri_new_ast_channel().
> 
> 2) SS7/PRI transfer capability interaction in dahdi_new() fixed because of SS7 extraction.
> 
> 3) Module ref count error in dahdi_new() if startpbx failed to start the PBX for some reason.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/Makefile 263201 
>   /trunk/channels/chan_dahdi.c 263201 
>   /trunk/channels/sig_pri.h 263201 
>   /trunk/channels/sig_pri.c 263201 
>   /trunk/channels/sig_ss7.h PRE-CREATION 
>   /trunk/channels/sig_ss7.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/661/diff
> 
> 
> Testing
> -------
> 
> Made test calls between T1 ports on a test box.
> 
> 
> Thanks,
> 
> rmudgett
> 
>