[asterisk-dev] [Code Review] feature.conf attended transfer external tests

[Jeff Peeler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/659/#review2073
-----------------------------------------------------------

Ship it!


My comments are universal, but good job.


/asterisk/trunk/tests/feature_attended_transfer/configs/extensions.conf
<https://reviewboard.asterisk.org/r/659/#comment4368>

    I would also indicate why you are using playback as timing rather than something like wait.



/asterisk/trunk/tests/feature_attended_transfer/configs/extensions.conf
<https://reviewboard.asterisk.org/r/659/#comment4367>

    Suggestion: comment these params



/asterisk/trunk/tests/feature_attended_transfer/run-test
<https://reviewboard.asterisk.org/r/659/#comment4366>

    Do the asterisk start calls run asynchronously? If not, why aren't you executing launch_test without the reactor?


- Jeff


On 2010-05-18 16:46:29, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/659/
> -----------------------------------------------------------
> 
> (Updated 2010-05-18 16:46:29)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> These external tests exercise the 'atxfer' option in features.conf.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/feature_attended_transfer/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_attended_transfer/configs/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_attended_transfer/configs/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_attended_transfer/configs2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_attended_transfer/configs2/features.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_attended_transfer/configs2/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_attended_transfer/configs2/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_attended_transfer/run-test PRE-CREATION 
>   /asterisk/trunk/tests/feature_attended_transfer/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/feature_blonde_transfer/blonde_configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_blonde_transfer/blonde_configs/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_blonde_transfer/blonde_configs/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_blonde_transfer/blonde_configs2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_blonde_transfer/blonde_configs2/features.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_blonde_transfer/blonde_configs2/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_blonde_transfer/blonde_configs2/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/feature_blonde_transfer/run-test PRE-CREATION 
>   /asterisk/trunk/tests/feature_blonde_transfer/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/659/diff
> 
> 
> Testing
> -------
> 
> I ran these tests using 1.4 - trunk and verified they all pass.  There is however a segfault that occurs about 15% of the time with trunk at the moment that I will solve before committing this.
> 
> 
> Thanks,
> 
> David
> 
>