[asterisk-dev] [Code Review] new testcase to test loading / unloading for modules.

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/653/#review2067
-----------------------------------------------------------



/asterisk/trunk/lib/python/asterisk/asterisk.py
<https://reviewboard.asterisk.org/r/653/#comment4353>

    Why getBase()?  You can get base directly.



/asterisk/trunk/lib/python/asterisk/asterisk.py
<https://reviewboard.asterisk.org/r/653/#comment4354>

    This is a change in behavior.  The output is no longer sent to stdout while the CLI command runs.  It actually isn't sent to stdout at all, unless the caller of this function prints it there.



/asterisk/trunk/tests/dynamic-modules/run-test
<https://reviewboard.asterisk.org/r/653/#comment4356>

    I would suggest making this a list of tuples instead of a list of lists



/asterisk/trunk/tests/dynamic-modules/run-test
<https://reviewboard.asterisk.org/r/653/#comment4355>

    I would change the loop to be:
    
    for module in res:
    
    Then, you have a direct reference to the current element instead of having to write code using the array index.



/asterisk/trunk/tests/dynamic-modules/run-test
<https://reviewboard.asterisk.org/r/653/#comment4357>

    same enumeration suggestion here


- Russell


On 2010-05-13 15:34:09, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/653/
> -----------------------------------------------------------
> 
> (Updated 2010-05-13 15:34:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is my first test-case used to test the loading / unloading of modules.  Currently it only check res modules, once the core design is complete additional modules will be added.
> 
> I've create 2 new feature in the asterisk library, getBase (needed to check if modules actually exists / compiled) and CLI output (needed to confirm module was loaded / unloaded).
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/dynamic-modules/configs/modules.conf PRE-CREATION 
>   /asterisk/trunk/tests/dynamic-modules/run-test PRE-CREATION 
>   /asterisk/trunk/tests/dynamic-modules/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 295 
>   /asterisk/trunk/tests/dynamic-modules/configs/logger.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/asterisk.py 295 
> 
> Diff: https://reviewboard.asterisk.org/r/653/diff
> 
> 
> Testing
> -------
> 
> Local development / QA box. Not all modules tested yet, as I was missing the dependencies.
> 
> 
> Thanks,
> 
> pabelanger
> 
>