[asterisk-dev] [Code Review] Make fax modules log debug messages to a "FAX" logger level.

Matthew Nicholson mnicholson at digium.com
Thu May 20 17:21:19 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/658/#review2051
-----------------------------------------------------------

Ship it!


I tested this and it works great!

- Matthew


On 2010-05-20 16:56:00, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/658/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 16:56:00)
> 
> 
> Review request for Asterisk Developers, Kevin Fleming and Matthew Nicholson.
> 
> 
> Summary
> -------
> 
> Pretty simple. All fax-related messages from spandsp that previously went to the DEBUG logger level will be logged to a FAX logger level if possible.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/res_fax.h 264538 
>   /trunk/res/res_fax.c 264538 
>   /trunk/res/res_fax.exports.in 264538 
>   /trunk/res/res_fax_spandsp.c 264538 
> 
> Diff: https://reviewboard.asterisk.org/r/658/diff
> 
> 
> Testing
> -------
> 
> It compiles. If someone wishes to run a fax using res_fax_spandsp with this patch and let me know if the messages are logged to the FAX channel properly, that would be great.
> 
> 
> Thanks,
> 
> Mark
> 
>




More information about the asterisk-dev mailing list