[asterisk-dev] [Code Review] Parsing of reg->username containing @domain

[David Vossel]

> On 2010-05-20 11:47:12, David Vossel wrote:
> > trunk/channels/chan_sip.c, line 11610
> > <https://reviewboard.asterisk.org/r/628/diff/9/?file=10324#file10324line11610>
> >
> >     What if there is a fromdomain without a fromdomainport and a regdomain with a regdomainport.  That would mean fromdomain would get matched with regdomain's port later.
> >     
> >     This is a crazy edge case, but it appears possible.  We just need to make sure the port matches up correctly with the domain.
> 
> Nick Lewis wrote:
>     I think a peername in the register string is an edge case and anyone doing it should be pushed over. Having got that off my chest I will look to fixing these

Agreed.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/628/#review2041
-----------------------------------------------------------


On 2010-05-20 04:37:10, Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/628/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 04:37:10)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> reg->username is parsed for each registration refresh rather than once on sip reload. A previously committed change that addressed this was reverted because it did not cater for registration strings that contained a peer name in the host field. This change does. 
> 
> 
> This addresses bug 14331.
>     https://issues.asterisk.org/view.php?id=14331
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 258227 
>   trunk/channels/sip/config_parser.c 258227 
>   trunk/channels/sip/include/sip.h 258228 
>   trunk/main/app.c 258227 
> 
> Diff: https://reviewboard.asterisk.org/r/628/diff
> 
> 
> Testing
> -------
> 
> Passes a new unit test for parsing usernames containing domains. Passes existing unit tests. Passes peername functional test with sip.conf snippet
> 
> [general]
> register=nick at quirk
> [quirk]
> fromdomain=10.10.235.48
> 
> 
> Thanks,
> 
> Nick
> 
>