[asterisk-dev] [Code Review] Parsing of reg->username containing @domain

[Nick Lewis]

> On 2010-05-18 16:19:29, David Vossel wrote:
> > Nick, The progress you made with splitting up the port from fromdomain is incomplete.  There is a general fromdomain option (default_fromdomain variable in the code) that can be set globally.  There are places that this value is copied over to the dialog where the port is not pulled out.
> > 
> > I don't mind altering your previous patch to account for the domainport in transmit_register() and committing this as it was, but if you feel like continuing with this patch and splitting up the fromdomain and fromdomainport further I'll review it again.  Let me know how you would like to proceed.
> > 
> > Thanks again for all your hard work!  Sorry my feedback is so slow at the moment.

Thanks for identifying this omission

Having come this far I am determined to complete the task of removing config parsing from re-registration

I do very much appreciate your substantive feedback (especially since my feedback has been bizarre) 


- Nick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/628/#review2023
-----------------------------------------------------------


On 2010-05-12 10:00:39, Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/628/
> -----------------------------------------------------------
> 
> (Updated 2010-05-12 10:00:39)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> reg->username is parsed for each registration refresh rather than once on sip reload. A previously committed change that addressed this was reverted because it did not cater for registration strings that contained a peer name in the host field. This change does. 
> 
> 
> This addresses bug 14331.
>     https://issues.asterisk.org/view.php?id=14331
> 
> 
> Diffs
> -----
> 
>   trunk/channels/sip/include/sip.h 258228 
>   trunk/main/app.c 258227 
>   trunk/channels/chan_sip.c 258227 
>   trunk/channels/sip/config_parser.c 258227 
> 
> Diff: https://reviewboard.asterisk.org/r/628/diff
> 
> 
> Testing
> -------
> 
> Passes a new unit test for parsing usernames containing domains. Passes existing unit tests. Passes peername functional test with sip.conf snippet
> 
> [general]
> register=nick at quirk
> [quirk]
> fromdomain=10.10.235.48
> 
> 
> Thanks,
> 
> Nick
> 
>