[asterisk-dev] [Code Review] Dial and queue connected line update macro not always run when expected.

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/669/
-----------------------------------------------------------

Review request for Asterisk Developers and Mark Michelson.


Summary
-------

The connected line update macro would not get run if the connected line number string was empty.  The number could be empty if the connected line update did not update a number but the name.  It should be run if there was an AST_CONTROL_CONNECTED_LINE frame received for pending dials and queues.

Renamed and added some more comments for some confusing identifiers directly connected to the related code.

Also fixed a memory leak in app_queue.


Diffs
-----

  /trunk/apps/app_dial.c 264496 
  /trunk/apps/app_queue.c 264496 

Diff: https://reviewboard.asterisk.org/r/669/diff


Testing
-------

Compile testing.


Thanks,

rmudgett