[asterisk-dev] [Code Review] Make fax modules log debug messages to a "FAX" logger level.

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/658/#review2032
-----------------------------------------------------------

Ship it!


This looks great, I can't find anything wrong with it.  It would be nice if someone could verify it works before committing it though.

- David


On 2010-05-11 10:24:14, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/658/
> -----------------------------------------------------------
> 
> (Updated 2010-05-11 10:24:14)
> 
> 
> Review request for Asterisk Developers, Kevin Fleming and Matthew Nicholson.
> 
> 
> Summary
> -------
> 
> Pretty simple. All fax-related messages from spandsp that previously went to the DEBUG logger level will be logged to a FAX logger level if possible.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_fax_spandsp.c 262241 
>   /trunk/include/asterisk/res_fax.h 262241 
>   /trunk/res/res_fax.c 262241 
> 
> Diff: https://reviewboard.asterisk.org/r/658/diff
> 
> 
> Testing
> -------
> 
> It compiles. If someone wishes to run a fax using res_fax_spandsp with this patch and let me know if the messages are logged to the FAX channel properly, that would be great.
> 
> 
> Thanks,
> 
> Mark
> 
>