[asterisk-dev] [Code Review] New python module to facilitate monitoring manager events

David Vossel dvossel at digium.com
Tue May 18 17:21:14 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/637/#review2027
-----------------------------------------------------------



/asterisk/trunk/lib/python/client.py
<https://reviewboard.asterisk.org/r/637/#comment4310>

    The EventWatcher creates the Asterisk instance, which currently restricts what configs are installed.   Could we get an option to set the Asterisk instance the EventWatcher is going to have control over on initialization?
    
    This would mean creating the Asterisk instance first, setting all the config information, and then passing it to the EventWatch to handle.
    


- David


On 2010-05-18 16:58:05, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/637/
> -----------------------------------------------------------
> 
> (Updated 2010-05-18 16:58:05)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a event manager module that is designed to make monitoring for events very easy. More information of described functionality is present in the run-tests sample test file. Also, I see all the whitespace and will correct it before committing.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/client.py PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/configs/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/configs/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/run-test PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/starpy.conf PRE-CREATION 
>   /asterisk/trunk/tests/ami-monitor/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/637/diff
> 
> 
> Testing
> -------
> 
> Lots of testing has been done along the way, mostly verifying the supported event scenarios work as expected. Currently the only event test present in the sample test module is monitoring the response to a ping event.
> 
> 
> Thanks,
> 
> Jeff
> 
>




More information about the asterisk-dev mailing list