[asterisk-dev] [Code Review] Extract sig_ss7 out of chan_dahdi.

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/661/#review2012
-----------------------------------------------------------


I will remove the red spots from my changes.


/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/661/#comment4298>

    Pesky red spots


- rmudgett


On 2010-05-14 17:02:54, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/661/
> -----------------------------------------------------------
> 
> (Updated 2010-05-14 17:02:54)
> 
> 
> Review request for Asterisk Developers and mattf.
> 
> 
> Summary
> -------
> 
> Extract the SS7 specific code out of chan_dahdi like what was done to ISDN/PRI and analog signaling.  The new SS7 structures were modeled on sig_pri.
> 
> The changes to sig_pri are an enhancement and a bug fix made possible because SS7 was extracted.
> 1) The sig_pri TRANSFERCAPABILITY channel variable should have been set unconditionally in sig_pri_new_ast_channel().
> 
> 2) SS7/PRI transfer capability interaction in dahdi_new() fixed because of SS7 extraction.
> 
> 3) Module ref count error in dahdi_new() if startpbx failed to start the PBX for some reason.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/Makefile 263200 
>   /trunk/channels/chan_dahdi.c 263200 
>   /trunk/channels/sig_pri.h 263200 
>   /trunk/channels/sig_pri.c 263200 
>   /trunk/channels/sig_ss7.h PRE-CREATION 
>   /trunk/channels/sig_ss7.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/661/diff
> 
> 
> Testing
> -------
> 
> Made test calls between T1 ports on a test box.
> 
> 
> Thanks,
> 
> rmudgett
> 
>