[asterisk-dev] [Code Review] PickupChan external tests

[David Vossel]

> On 2010-05-12 10:07:57, Mark Michelson wrote:
> > /asterisk/trunk/tests/directed_pickup/test-config.yaml, line 7
> > <https://reviewboard.asterisk.org/r/660/diff/1/?file=10110#file10110line7>
> >
> >     I think you can safely change the minversion to 1.6.1. That's the version that brought in the PickupChan app and I don't notice anything 1.8-specific in your test.

This test uses a trunk specific option.  The 'p' option for picking up a partial channel name.  I felt weird about doing internal logic within the test to only run parts of it when certain versions were present.  It seemed like that was to be left up to a higher level script so I just limited it to 1.8 and higher.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/660/#review2001
-----------------------------------------------------------


On 2010-05-11 14:13:35, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/660/
> -----------------------------------------------------------
> 
> (Updated 2010-05-11 14:13:35)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This external test exercises the PickupChan application.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/directed_pickup/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/directed_pickup/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/directed_pickup/configs/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/directed_pickup/run-test PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/660/diff
> 
> 
> Testing
> -------
> 
> tested, verified it passes.
> 
> 
> Thanks,
> 
> David
> 
>